Pannier. The earth strap on the early GS runs to a T25 torx on top of the engine, pretty much at the base of the n/s cylinder.
It was in a horrible state and took an hour to finally get clean enough for me to be happy.
I have run resistance and continuity tests on all sorts of +ve and -ve leads and circuits. Bench run old starters, bench run the new starter, tested them running (but not installed) in the bike... all sorts.
I think the original fault may have been in the feed to the starter solenoid and this was probably fixed the first time I removed the relay which handles the high current circuit, as the handlebar button just activates that relay.
That fault, helped by a sump with at least 750ml too much oil was enough to prevent the engine from turning over freely, even with the plugs out. With the plugs out yesterday I was able to get the engine to turn over.... not quickly, these engines don't do that, but enough.
I then fully charged the new battery in the bike and a couple of jump batteries that we use to energise electric tape 'zappers' at the horses field, connected the whole lot together and the Beemer started first prod of the button. However, after running the engine up to temperature, the 'new' bike battery on its own would not turn the engine over... so I think we have culprit number two.
I'll be getting another battery, just as soon as I can find one I am sure can handle the task.