I have used a shock sock on all my bikes for the last 20 years, never had trapped moisture or corrosion issues.
I always use a velcro sock for the simple reason that it keeps the shock looking like new! I remove it once a year to check the shock, clean and lube if needed then stick it back on. Dirt doesn't get in there and the shocks always look great, would highly recommend one.